Feat(fixed_charges): update fixed_charge and subscription models #4466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groyoh
approved these changes
Oct 10, 2025
ancorcruz
approved these changes
Oct 10, 2025
annvelents
force-pushed
the
feat/fixed_charge-16/fixed_charge_fee_creation-1
branch
5 times, most recently
from
fd5b1bf to
23a842d
Compare
annvelents
commented
Oct 23, 2025
| fixed_charges_duration: dates_service.fixed_charges_duration_in_days | ||
| ) | ||
|
|
||
| InvoiceSubscription.matching?(self, previous_period_boundaries) ? boundaries : previous_period_boundaries |
Contributor
Author
There was a problem hiding this comment.
if we start populating this values, will it break? (comparing new invoice with stored in the db)
Contributor
Author
There was a problem hiding this comment.
firstly we want to make sure that subscriptions have these values! then we'll do some population of this values, and only after we can rely on this logic of adding fixed_charges into the comparison :(
Contributor
Author
There was a problem hiding this comment.
cancel all the worries, it only applies if "fixed_charges_billed_in_monthly_split_intervals" - plan is yearly, fixed_charges are applied monthly 😌
annvelents
force-pushed
the
feat/fixed_charge-16/fixed_charge_fee_creation-1
branch
from
23a842d to
0e08a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As part of deconstruction of a big PR responsible for creating fixed charges fees, we need these missing updates in the models
Description
added new scope to a fixed_charge
fix validations to not throw warnings during tests
added included_in_next_subscription to a fixed charge
added fixed_charge boundaries to subscription's adjusted_boundaries